Review Request 124007: Don't add functions for code-completion based on parameters.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124007/#review81266
-----------------------------------------------------------



codecompletion/context.cpp (line 430)
<https://git.reviewboard.kde.org/r/124007/#comment55695>

    return nullptr;
    
    not sure what {} gives you here otherwise



codecompletion/context.cpp 
<https://git.reviewboard.kde.org/r/124007/#comment55693>

    just to clarify: this is not required anymore, now that overloaded functions are properly handled - correct?



codecompletion/context.cpp (line 657)
<https://git.reviewboard.kde.org/r/124007/#comment55694>

    else it gets lost - is that correct?


- Milian Wolff


On June 6, 2015, 7:34 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124007/
> -----------------------------------------------------------
> 
> (Updated June 6, 2015, 7:34 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> E.g.: class Abc; int f(Abc){ Ab|
> Completion invoked at the "|", that gives us "Abc" as a completion result. Before this we had "Abc" and "f(Abc)", which is obviously wrong.
>   
> Also this makes the "Detailed completion" option work.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 2bf8c81 
>   tests/test_codecompletion.cpp 470dcc0 
> 
> Diff: https://git.reviewboard.kde.org/r/124007/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150606/18b6444d/attachment.html>