Review Request 124007: Don't add functions for code-completion based on parameters.

Sergey Kalinichev kalinichev.so.0 at gmail.com
Sat Jun 6 07:34:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124007/
-----------------------------------------------------------

(Updated June 6, 2015, 10:34 a.m.)


Review request for KDevelop.


Changes
-------

Don't add function signature for declaration items. 

This is a slightly different approach which allows us to simplify logic regarding overloaded functions and also it speeds up code completion for me for about 50ms on average.


Repository: kdev-clang


Description
-------

E.g.: class Abc; int f(Abc){ Ab|
Completion invoked at the "|", that gives us "Abc" as a completion result. Before this we had "Abc" and "f(Abc)", which is obviously wrong.
  
Also this makes the "Detailed completion" option work.


Diffs (updated)
-----

  codecompletion/context.cpp 2bf8c81 
  tests/test_codecompletion.cpp 470dcc0 

Diff: https://git.reviewboard.kde.org/r/124007/diff/


Testing
-------


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150606/52402b72/attachment.html>


More information about the KDevelop-devel mailing list