Review Request 123900: GDB plugin enhancements and some command queue optimizations for master branch

[Milian Wolff]

> On May 26, 2015, 7:40 a.m., Milian Wolff wrote:
> >
> 
> Andreas Roth wrote:
>     @Milian: Can you please commit this for me since i don't have write permission to the repo. Thx.

I could, but I'd rather have the individual commits merged - up to which commit should I merge from https://github.com/aroth-arsoft/kdevelop/tree/master-gdb-enhancements ?

Also, could you please run the unit tests - do they work for you? For me, the GDB test even crashes nowadays and is really unstable. It would be really nice if you could somehow first make sure the unit tests work and/or we get expected failures before merging new refactorings.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123900/#review80833
-----------------------------------------------------------


On May 27, 2015, 5:03 a.m., Andreas Roth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123900/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 5:03 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Basically this contains the same changes as https://git.reviewboard.kde.org/r/121456/ but for the master branch.
> 
> Repo is available at https://github.com/aroth-arsoft/kdevelop/tree/master-gdb-enhancements
> - switch the assembler flavor from AT&T to Intel and back in the dissassembler widget
> - remove StackList commands from the queue when a new Exec command arrives. This reduces the wait time when stepping through the code quickly.
> - remove duplicated command in the queue. Mostly to eliminate duplicate variable updates.
> - show the pending command in the command queue. This is purely for debugging and to check which commands are currently pending.
> - slight improvements to memory view to use sizeof() when no size argument is given
> -
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/debugsession.cpp fe015ae915f190cef266f1c52d0cedf16dfb9007 
>   debuggers/gdb/disassemblewidget.h c49e5bc1d9a9234888006e91127a880ef257ba23 
>   debuggers/gdb/disassemblewidget.cpp ee7733faadabf36bbdf88a627372031c95710d21 
>   debuggers/gdb/gdb.cpp 66fee9e2f5f44a2f76564d9df5f701689a27a874 
>   debuggers/gdb/gdbcommand.h 692c0ac6b6a98b71678f2aa89b8f7940ed390a2e 
>   debuggers/gdb/gdbcommand.cpp 3207fdc896ec0dd0f7de319547bf4302042872a4 
>   debuggers/gdb/gdbcommandqueue.h 9525301bf0614d7613d58ae4dfdcc08da709f7b4 
>   debuggers/gdb/gdbcommandqueue.cpp 4bf11d0bd68e1aa0ef1cf2a8008011cf0fb76a55 
>   debuggers/gdb/memviewdlg.cpp 08034e6631fc8f103005471a08cf0df031ff85f3 
> 
> Diff: https://git.reviewboard.kde.org/r/123900/diff/
> 
> 
> Testing
> -------
> 
> manual testing so far
> 
> 
> Thanks,
> 
> Andreas Roth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150605/8eadd59d/attachment.html>