Review Request 124012: Replace cacheIterator with Iterator Returned from erase

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124012/#review81220
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On June 5, 2015, 7:07 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124012/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 7:07 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> It's in general a bad idea to keep iterators to modified containers. In
> particular, this was causing a crash in a very strange corner case I did
> not fully understand, but this change fixed it.
> 
> 
> Diffs
> -----
> 
>   project/projectbuildsetmodel.cpp 64a50afb815eb2cbbe2ae1e1ee6d808df3927135 
> 
> Diff: https://git.reviewboard.kde.org/r/124012/diff/
> 
> 
> Testing
> -------
> 
> The crash used to happen when I was removing stuff from my build set, but I don't really know how to reproduce it properly.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150605/a4045b00/attachment-0001.html>