Review Request 124003: Speed up grep output view

Aleix Pol Gonzalez aleixpol at kde.org
Thu Jun 4 10:11:42 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124003/#review81168
-----------------------------------------------------------


Looks interesting!
Do you know what's exactly the part that is making your views struggle? Why isn't resizeColumnToContents needed anymore?

- Aleix Pol Gonzalez


On June 4, 2015, 11:56 a.m., Oleksandr Senkovych wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124003/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 11:56 a.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Grep output view is very laggy if there is a lot of items. For example on my machine adding just 300 items to this view takes about 10 seconds and whole KDevelop UI becomes unresponsive. After applying proposed changes there is no problem to add even 10 000 items - everything works without any lag. 
> Also, I didn't notice any regression in the UI: all rows in the view are displayed properly.
> 
> 
> Diffs
> -----
> 
>   plugins/grepview/grepoutputview.h 5191c58 
>   plugins/grepview/grepoutputview.cpp 2fba779 
> 
> Diff: https://git.reviewboard.kde.org/r/124003/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oleksandr Senkovych
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150604/3fb099d0/attachment.html>


More information about the KDevelop-devel mailing list