Review Request 124000: Fix override code-completion

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124000/#review81157
-----------------------------------------------------------

Ship it!


good one!


codecompletion/completionhelper.h (line 38)
<https://git.reviewboard.kde.org/r/124000/#comment55566>

    this should be const and we usually write operators-functions without the spaces around the operator, i.e. here:
    
        bool operator==(const FuncOverrideInfo& rhs) const;



codecompletion/completionhelper.cpp (line 291)
<https://git.reviewboard.kde.org/r/124000/#comment55567>

    you can safe some typing by using tuple here:
    
        return std::make_tuple(returnType, name, params, isConst)
            == std::make_tuple(rhs.returnType, rhs.name, rhs.params, rhs.isConst);


- Milian Wolff


On June 4, 2015, 7:38 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124000/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 7:38 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> It shouldn't offer to override already overridden methods.
> 
> 
> Diffs
> -----
> 
>   codecompletion/completionhelper.h 030b2ae 
>   codecompletion/completionhelper.cpp 51abdc2 
>   tests/test_codecompletion.cpp 24566d3 
> 
> Diff: https://git.reviewboard.kde.org/r/124000/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150604/51011684/attachment.html>