<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124000/">https://git.reviewboard.kde.org/r/124000/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">good one!</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124000/diff/1/?file=378740#file378740line38" style="color: black; font-weight: bold; text-decoration: underline;">codecompletion/completionhelper.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct FuncOverrideInfo</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">bool</span> <span class="n">operator</span> <span class="o">==</span> <span class="p">(</span><span class="k">const</span> <span class="n">FuncOverrideInfo</span><span class="o">&</span> <span class="n">rhs</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this should be const and we usually write operators-functions without the spaces around the operator, i.e. here:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">bool operator==(const FuncOverrideInfo& rhs) const;
</pre></div>
</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124000/diff/1/?file=378741#file378741line316" style="color: black; font-weight: bold; text-decoration: underline;">codecompletion/completionhelper.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">291</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">returnType</span> <span class="o">==</span> <span class="n">rhs</span><span class="p">.</span><span class="n">returnType</span> <span class="o">&&</span> <span class="n">name</span> <span class="o">==</span> <span class="n">rhs</span><span class="p">.</span><span class="n">name</span> <span class="o">&&</span> <span class="n">params</span> <span class="o">==</span> <span class="n">rhs</span><span class="p">.</span><span class="n">params</span> <span class="o">&&</span> <span class="n">isConst</span> <span class="o">==</span> <span class="n">rhs</span><span class="p">.</span><span class="n">isConst</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you can safe some typing by using tuple here:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #008000; font-weight: bold">return</span> <span style="color: #008000; font-weight: bold">std</span><span style="color: #666666">:</span><span style="color: #AA22FF">:make_tuple</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">returnType</span><span style="color: #666666">,</span> <span style="color: #008000; font-weight: bold">name</span><span style="color: #666666">,</span> <span style="color: #008000; font-weight: bold">params</span><span style="color: #666666">,</span> <span style="color: #008000; font-weight: bold">isConst</span><span style="color: #666666">)</span>
<span style="color: #666666">==</span> <span style="color: #008000; font-weight: bold">std</span><span style="color: #666666">:</span><span style="color: #AA22FF">:make_tuple</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">rhs</span><span style="color: #0000FF; font-weight: bold">.returnType</span><span style="color: #666666">,</span> <span style="color: #008000; font-weight: bold">rhs</span><span style="color: #0000FF; font-weight: bold">.name</span><span style="color: #666666">,</span> <span style="color: #008000; font-weight: bold">rhs</span><span style="color: #0000FF; font-weight: bold">.params</span><span style="color: #666666">,</span> <span style="color: #008000; font-weight: bold">rhs</span><span style="color: #0000FF; font-weight: bold">.isConst</span><span style="color: #666666">);</span>
</pre></div>
</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On June 4th, 2015, 7:38 a.m. UTC, Sergey Kalinichev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated June 4, 2015, 7:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It shouldn't offer to override already overridden methods.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>codecompletion/completionhelper.h <span style="color: grey">(030b2ae)</span></li>
<li>codecompletion/completionhelper.cpp <span style="color: grey">(51abdc2)</span></li>
<li>tests/test_codecompletion.cpp <span style="color: grey">(24566d3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124000/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>