Review Request 123960: Set empty ranges for uses of some operators
Olivier Jean de Gaalon
olivier.jg at gmail.com
Mon Jun 1 05:25:49 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123960/#review81028
-----------------------------------------------------------
Note that this is a somewhat hot spot, so stringifying every single use to test if it's a use of operator[] would be very nice to avoid. At least we should ensure the cursor kind is a CXXMethod.
However, looking through the API, I wonder if the problem you're trying to solve isn't just a matter of removing CXNameRange_WantSinglePiece from the clang_getCursorReferenceNameRange call. At least for C++, it sounds like it would do exactly what you're looking for. We can let someone who cares about Obj-C think about what that means to them.
duchain/builder.cpp (line 1096)
<https://git.reviewboard.kde.org/r/123960/#comment55488>
Typo: referencedCursorKind
- Olivier Jean de Gaalon
On May 31, 2015, 5:12 p.m., Sergey Kalinichev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123960/
> -----------------------------------------------------------
>
> (Updated May 31, 2015, 5:12 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdev-clang
>
>
> Description
> -------
>
> Once again, uses of those operators invisible, no need to highlight them
>
>
> Diffs
> -----
>
> duchain/builder.cpp 0acde9a
> tests/files/operators.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/123960/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Kalinichev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150601/1e643c63/attachment-0001.html>
More information about the KDevelop-devel
mailing list