Review Request 124514: Don't crash on Q_ASSERT(!jobs.contains(nullptr)) if cancelling the builder config dialog

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124514/#review83223
-----------------------------------------------------------


I wouldn't want that, I prefer returning error jobs. See: http://commits.kde.org/kdevelop/86f139ceb9a8662a1464c17cff1f7003b7ace9b9

Thanks for pointing it out and making me fix my shit! :)

- Aleix Pol Gonzalez


On July 29, 2015, 4:11 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124514/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 4:11 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Seems `IProjectBuilder::build(ProjectBaseItem *item)` does not require that a job is returned, at least `CMakeBuilder` feels free to just return `0`, e.g. if the user cancels the dialog.
> 
> Thus `CMakeManager::createImportJob(ProjectFolderItem* item)` better deals with that, and only adds the result to the call of that method to jobs if it really is a job. Not only because `Q_ASSERT(!jobs.contains(nullptr));` a few lines later will complain badly to anyone running a debug build... ;)
> 
> No idea if `KDevelop::AbstractFileManagerPlugin::createImportJob()` should get the same handling, not investigated, only ran in the issue handled here.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/cmakemanager.cpp 2b18fb5 
> 
> Diff: https://git.reviewboard.kde.org/r/124514/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150731/2e1129d7/attachment.html>