Review Request 124501: Move all refactoring actions to background

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124501/#review83194
-----------------------------------------------------------

Ship it!



refactoring/refactoringcontext.cpp (line 78)
<https://git.reviewboard.kde.org/r/124501/#comment57452>

    ::warning is better here.


- Milian Wolff


On July 27, 2015, 11:32 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124501/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 11:32 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Move all refactoring actions to background
> 
> Currently when refactoring is performed (in background) modal dialog is displayed (preventing user from changes to code). This dialog probably can be closed somehow, but it doesn't mean *interruption* is supported.
> 
> And this is end of `interface.h` history. After backgrounding actions, last use of `refactorThis` was removed from code and the whole interface become dead code...
> Current interface consists of `RefactoringContext` and `RefactoringManager` objects.
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/changesignaturerefactoring.h PRE-CREATION 
>   refactoring/changesignaturerefactoring.cpp PRE-CREATION 
>   refactoring/contextmenumutator.cpp PRE-CREATION 
>   refactoring/declarationcomparator.cpp PRE-CREATION 
>   refactoring/documentcache.cpp PRE-CREATION 
>   refactoring/encapsulatefieldrefactoring.cpp PRE-CREATION 
>   refactoring/interface.h PRE-CREATION 
>   refactoring/interface.cpp PRE-CREATION 
>   refactoring/kdevrefactorings.h PRE-CREATION 
>   refactoring/kdevrefactorings.cpp PRE-CREATION 
>   refactoring/nooprefactoring.cpp PRE-CREATION 
>   refactoring/refactoring.h PRE-CREATION 
>   refactoring/refactoring.cpp PRE-CREATION 
>   refactoring/refactoringcontext.h PRE-CREATION 
>   refactoring/refactoringcontext.cpp PRE-CREATION 
>   refactoring/renamefielddeclrefactoring.h PRE-CREATION 
>   refactoring/renamefielddeclrefactoring.cpp PRE-CREATION 
>   refactoring/renamefielddeclturefactoring.h PRE-CREATION 
>   refactoring/renamefielddeclturefactoring.cpp PRE-CREATION 
>   refactoring/renamevardeclrefactoring.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124501/diff/
> 
> 
> Testing
> -------
> 
> Manual testing
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150730/53d074db/attachment-0001.html>