Review Request 124501: Move all refactoring actions to background
Maciej Poleski
d82ks8djf82msd83hf8sc02lqb5gh5 at gmail.com
Mon Jul 27 23:32:00 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124501/
-----------------------------------------------------------
Review request for KDevelop and Milian Wolff.
Repository: kdev-clang
Description
-------
Move all refactoring actions to background
Currently when refactoring is performed (in background) modal dialog is displayed (preventing user from changes to code). This dialog probably can be closed somehow, but it doesn't mean *interruption* is supported.
And this is end of `interface.h` history. After backgrounding actions, last use of `refactorThis` was removed from code and the whole interface become dead code...
Current interface consists of `RefactoringContext` and `RefactoringManager` objects.
Diffs
-----
refactoring/CMakeLists.txt PRE-CREATION
refactoring/changesignaturerefactoring.h PRE-CREATION
refactoring/changesignaturerefactoring.cpp PRE-CREATION
refactoring/contextmenumutator.cpp PRE-CREATION
refactoring/declarationcomparator.cpp PRE-CREATION
refactoring/documentcache.cpp PRE-CREATION
refactoring/encapsulatefieldrefactoring.cpp PRE-CREATION
refactoring/interface.h PRE-CREATION
refactoring/interface.cpp PRE-CREATION
refactoring/kdevrefactorings.h PRE-CREATION
refactoring/kdevrefactorings.cpp PRE-CREATION
refactoring/nooprefactoring.cpp PRE-CREATION
refactoring/refactoring.h PRE-CREATION
refactoring/refactoring.cpp PRE-CREATION
refactoring/refactoringcontext.h PRE-CREATION
refactoring/refactoringcontext.cpp PRE-CREATION
refactoring/renamefielddeclrefactoring.h PRE-CREATION
refactoring/renamefielddeclrefactoring.cpp PRE-CREATION
refactoring/renamefielddeclturefactoring.h PRE-CREATION
refactoring/renamefielddeclturefactoring.cpp PRE-CREATION
refactoring/renamevardeclrefactoring.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/124501/diff/
Testing
-------
Manual testing
Thanks,
Maciej Poleski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150727/9ac2358f/attachment.html>
More information about the KDevelop-devel
mailing list