Review Request 124420: Added toggle targets to project view to hide targets from the view.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124420/#review82939
-----------------------------------------------------------

Ship it!


some minor nitpicks, otherwise +1

what's missing though is storing that setting somewhere and keeping it "alive" across session restarts.


project/projectproxymodel.cpp (line 24)
<https://git.reviewboard.kde.org/r/124420/#comment57239>

    push to new line and align , with : please



project/projectproxymodel.cpp (line 53)
<https://git.reviewboard.kde.org/r/124420/#comment57240>

    braces missing



project/projectproxymodel.cpp (line 54)
<https://git.reviewboard.kde.org/r/124420/#comment57242>

    return true, or do we actually use the filter functionality anywhere? not as far as I'm aware.



project/projectproxymodel.cpp (line 58)
<https://git.reviewboard.kde.org/r/124420/#comment57241>

    remove space before (, use auto item = ...;



project/projectproxymodel.cpp (line 60)
<https://git.reviewboard.kde.org/r/124420/#comment57244>

    return item->type() != KDevelop::ProjectBaseItem::Target;


- Milian Wolff


On July 22, 2015, 4:27 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124420/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 4:27 p.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez and Kevin Funk.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Added toggle targets to project view to hide targets from the view.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/projectmanagerview.h 57774ffac08219605b4e630ad2199315e84999ef 
>   plugins/projectmanagerview/projectmanagerview.cpp dcf4d34ba1037704a49f6d76b10b5cb0ee223a45 
>   project/projectproxymodel.h 6feba146ac083f8082964dc77a8565974891cc8b 
>   project/projectproxymodel.cpp 995c29b200f3897723627c891cc848107cebc513 
> 
> Diff: https://git.reviewboard.kde.org/r/124420/diff/
> 
> 
> Testing
> -------
> 
> Button works and hides/shows targets in the Project pane.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150725/cef66bcf/attachment.html>