Review Request 124420: Added toggle targets to project view to hide targets from the view.

Milian Wolff mail at milianw.de
Sat Jul 25 13:35:48 UTC 2015



> On July 24, 2015, 9:19 a.m., Milian Wolff wrote:
> > I'd prefer this functionality to be added to the project filter functionality, instead of adding yet another filter somewhere. Could you do that?
> 
> Jeremy Whiting wrote:
>     Yep, I can do that. Could you point me to where the project filter functionality sources are? I'm not very familiar with the project just yet.
> 
> Aleix Pol Gonzalez wrote:
>     @milian, I'm not sure this is the best way to approach this because:
>     * The targets should stay in the model (Otherwise the menu in "Run configurations" won't work).
>     * We're filtering out of the UI, but they're still part of the project.
> 
> Milian Wolff wrote:
>     It's in kdevplatform/plugins/projectfilter.
>     
>     Thanks!

meh I didn't see the update. Aleix is right, so your current approach is probably fine then.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124420/#review82862
-----------------------------------------------------------


On July 22, 2015, 4:27 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124420/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 4:27 p.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez and Kevin Funk.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Added toggle targets to project view to hide targets from the view.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/projectmanagerview.h 57774ffac08219605b4e630ad2199315e84999ef 
>   plugins/projectmanagerview/projectmanagerview.cpp dcf4d34ba1037704a49f6d76b10b5cb0ee223a45 
>   project/projectproxymodel.h 6feba146ac083f8082964dc77a8565974891cc8b 
>   project/projectproxymodel.cpp 995c29b200f3897723627c891cc848107cebc513 
> 
> Diff: https://git.reviewboard.kde.org/r/124420/diff/
> 
> 
> Testing
> -------
> 
> Button works and hides/shows targets in the Project pane.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150725/052451fb/attachment-0001.html>


More information about the KDevelop-devel mailing list