Review Request 124378: Remove unrelated items from the "Best matches" completion group

Sergey Kalinichev kalinichev.so.0 at gmail.com
Tue Jul 21 07:54:06 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124378/
-----------------------------------------------------------

(Updated July 21, 2015, 7:54 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Changes
-------

Submitted with commit f4a4a4efddc69d09a559eb546c87ab14b21ed64e by Sergey Kalinichev to branch master.


Repository: kdev-clang


Description
-------

Currently this group contains too many elements which can never be the exact match. This happens because clang's code-completion considers all classes and pointers as similar. E.g.: "class A; class B; A a; B b="
Here the "a" is considered as similar to the "b", therefore it has high completion priority. To avoid it let's manually adjust the priority.

Also sort all items by priority, not only the Best mathes group. The InheritanceDepth is used for that.


Diffs
-----

  codecompletion/context.cpp f26921f 
  tests/test_codecompletion.h 088351f 
  tests/test_codecompletion.cpp 7623737 

Diff: https://git.reviewboard.kde.org/r/124378/diff/


Testing
-------


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150721/a0467bf3/attachment.html>


More information about the KDevelop-devel mailing list