Review Request 124378: Remove unrelated items from the "Best matches" completion group

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124378/#review82702
-----------------------------------------------------------

Ship it!


minor nitpicks, otherwise looks good - awesome!


codecompletion/context.cpp (line 359)
<https://git.reviewboard.kde.org/r/124378/#comment57039>

    const auto type = decl->abstractType();
    
        if (type) {
            const whichType = type->whichType();
            if (whichType == ...) {
                ...
            } else if (whichType == ...) {
                ...
            }
        }



codecompletion/context.cpp (line 361)
<https://git.reviewboard.kde.org/r/124378/#comment57038>

    space before {


- Milian Wolff


On July 17, 2015, 9:48 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124378/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 9:48 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Currently this group contains too many elements which can never be the exact match. This happens because clang's code-completion considers all classes and pointers as similar. E.g.: "class A; class B; A a; B b="
> Here the "a" is considered as similar to the "b", therefore it has high completion priority. To avoid it let's manually adjust the priority.
> 
> Also sort all items by priority, not only the Best mathes group. The InheritanceDepth is used for that.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp f26921f 
>   tests/test_codecompletion.h 088351f 
>   tests/test_codecompletion.cpp 7623737 
> 
> Diff: https://git.reviewboard.kde.org/r/124378/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150720/b079935e/attachment-0001.html>