Review Request 124411: Display issues in the problems toolview, instead of a separate dedicated toolview.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124411/#review82737
-----------------------------------------------------------



CMakeLists.txt (line 67)
<https://git.reviewboard.kde.org/r/124411/#comment57054>

    Hmm.. shell shouldn't be needed from a plugin. I understand this is unrelated but we'll have to move the class to kdevlanguage (or maybe utils).



iparser.h (line 28)
<https://git.reviewboard.kde.org/r/124411/#comment57053>

    kdevplatform/ isn't needed


- Aleix Pol Gonzalez


On July 21, 2015, 1:20 a.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124411/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 1:20 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-cppcheck
> 
> 
> Description
> -------
> 
> Up until now the plugin had it's own models and view, and toolview where it showed the issues. This patch makes it show the issues in a dedicated tab of the problems toolview. As a side effect, lots of code is removed!
> See the video:
> https://www.youtube.com/watch?v=mcfr-Kc46Yo
> 
> NOTE:
> The video shows more than the issues. It shows the entire new GUI of the plugin.
> I've already pushed the settings related GUI changes, so the relevant part starts around 0:15 in the video.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 58a6a85 
>   ChangeLog a5110f7 
>   back/cppcheck_file_model.h 7ab8652 
>   back/cppcheck_file_model.cpp 8b7d997 
>   config/genericconfigpage.cpp 03dafbf 
>   config/ui/genericconfig.ui 03d74d3 
>   icppcheckitem.h b9a8c6f 
>   imodel.h 6b873c7 
>   imodel.cpp 70f18dd 
>   iparser.h b5b136f 
>   iview.h 24cf8ae 
>   job.h abb0514 
>   job.cpp 42b9c09 
>   kcm_kdev_cppcheck.json 67c3053 
>   marks.h 330813c 
>   marks.cpp d5aaf3b 
>   models/cppcheck_file_item.h c37f10f 
>   models/cppcheck_file_item.cpp 80b16f4 
>   models/cppcheck_file_model.h 566fabf 
>   models/cppcheck_file_model.cpp be6fe74 
>   models/cppcheck_severity_item.h 27d0242 
>   models/cppcheck_severity_item.cpp 1ae2c42 
>   models/cppcheck_severity_model.h 6feb92e 
>   models/cppcheck_severity_model.cpp c33e163 
>   models/cppcheckitems.h 537edd0 
>   models/cppcheckitemsimpl.h cfc64dc 
>   models/cppcheckitemsimpl.cpp 95162e7 
>   models/cppcheckmodel.h 3551e2e 
>   models/cppcheckmodel.cpp 60327a7 
>   modelwrapper.h 6c18078 
>   modelwrapper.cpp c568698 
>   parsers/cppcheckparser.h 1ba5148 
>   parsers/cppcheckparser.cpp 768986d 
>   plugin.h 882768e 
>   plugin.cpp 72030fb 
>   views/cppcheckview.h 31f36f2 
>   views/cppcheckview.cpp 7d1096f 
>   widget.h b5dc31a 
>   widget.cpp 971382f 
> 
> Diff: https://git.reviewboard.kde.org/r/124411/diff/
> 
> 
> Testing
> -------
> 
> * builds
> * works as intended
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150720/4095e0be/attachment.html>