<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124411/">https://git.reviewboard.kde.org/r/124411/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124411/diff/2/?file=386497#file386497line81" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KDev::Shell</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmm.. shell shouldn't be needed from a plugin. I understand this is unrelated but we'll have to move the class to kdevlanguage (or maybe utils).</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124411/diff/2/?file=386506#file386506line28" style="color: black; font-weight: bold; text-decoration: underline;">iparser.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <kdevplatform/interfaces/iproblem.h></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kdevplatform/ isn't needed</p></pre>
</div>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On July 21st, 2015, 1:20 a.m. CEST, Laszlo Kis-Adam wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Laszlo Kis-Adam.</div>
<p style="color: grey;"><i>Updated July 21, 2015, 1:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-cppcheck
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Up until now the plugin had it's own models and view, and toolview where it showed the issues. This patch makes it show the issues in a dedicated tab of the problems toolview. As a side effect, lots of code is removed!
See the video:
https://www.youtube.com/watch?v=mcfr-Kc46Yo</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">NOTE:
The video shows more than the issues. It shows the entire new GUI of the plugin.
I've already pushed the settings related GUI changes, so the relevant part starts around 0:15 in the video.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">builds</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">works as intended</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(58a6a85)</span></li>
<li>ChangeLog <span style="color: grey">(a5110f7)</span></li>
<li>back/cppcheck_file_model.h <span style="color: grey">(7ab8652)</span></li>
<li>back/cppcheck_file_model.cpp <span style="color: grey">(8b7d997)</span></li>
<li>config/genericconfigpage.cpp <span style="color: grey">(03dafbf)</span></li>
<li>config/ui/genericconfig.ui <span style="color: grey">(03d74d3)</span></li>
<li>icppcheckitem.h <span style="color: grey">(b9a8c6f)</span></li>
<li>imodel.h <span style="color: grey">(6b873c7)</span></li>
<li>imodel.cpp <span style="color: grey">(70f18dd)</span></li>
<li>iparser.h <span style="color: grey">(b5b136f)</span></li>
<li>iview.h <span style="color: grey">(24cf8ae)</span></li>
<li>job.h <span style="color: grey">(abb0514)</span></li>
<li>job.cpp <span style="color: grey">(42b9c09)</span></li>
<li>kcm_kdev_cppcheck.json <span style="color: grey">(67c3053)</span></li>
<li>marks.h <span style="color: grey">(330813c)</span></li>
<li>marks.cpp <span style="color: grey">(d5aaf3b)</span></li>
<li>models/cppcheck_file_item.h <span style="color: grey">(c37f10f)</span></li>
<li>models/cppcheck_file_item.cpp <span style="color: grey">(80b16f4)</span></li>
<li>models/cppcheck_file_model.h <span style="color: grey">(566fabf)</span></li>
<li>models/cppcheck_file_model.cpp <span style="color: grey">(be6fe74)</span></li>
<li>models/cppcheck_severity_item.h <span style="color: grey">(27d0242)</span></li>
<li>models/cppcheck_severity_item.cpp <span style="color: grey">(1ae2c42)</span></li>
<li>models/cppcheck_severity_model.h <span style="color: grey">(6feb92e)</span></li>
<li>models/cppcheck_severity_model.cpp <span style="color: grey">(c33e163)</span></li>
<li>models/cppcheckitems.h <span style="color: grey">(537edd0)</span></li>
<li>models/cppcheckitemsimpl.h <span style="color: grey">(cfc64dc)</span></li>
<li>models/cppcheckitemsimpl.cpp <span style="color: grey">(95162e7)</span></li>
<li>models/cppcheckmodel.h <span style="color: grey">(3551e2e)</span></li>
<li>models/cppcheckmodel.cpp <span style="color: grey">(60327a7)</span></li>
<li>modelwrapper.h <span style="color: grey">(6c18078)</span></li>
<li>modelwrapper.cpp <span style="color: grey">(c568698)</span></li>
<li>parsers/cppcheckparser.h <span style="color: grey">(1ba5148)</span></li>
<li>parsers/cppcheckparser.cpp <span style="color: grey">(768986d)</span></li>
<li>plugin.h <span style="color: grey">(882768e)</span></li>
<li>plugin.cpp <span style="color: grey">(72030fb)</span></li>
<li>views/cppcheckview.h <span style="color: grey">(31f36f2)</span></li>
<li>views/cppcheckview.cpp <span style="color: grey">(7d1096f)</span></li>
<li>widget.h <span style="color: grey">(b5dc31a)</span></li>
<li>widget.cpp <span style="color: grey">(971382f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124411/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>