Review Request 124400: Display problems in the Problems toolview, set parameters in project settings, start from run menu.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124400/#review82717
-----------------------------------------------------------


+1 lgtm.

BTW, +564 -6114 seems amazing.

- Aleix Pol Gonzalez


On July 20, 2015, 3:45 p.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124400/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 3:45 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-krazy2
> 
> 
> Description
> -------
> 
> Up until now the plugin used it's own toolview to set parameters, run krazy, and show issues. This patch moves the issues to a tab in the problems toolview, moves the settings to the project settings, and the tool can now be started from the run menu.
> 
> See video:
> https://www.youtube.com/watch?v=gP81N07T5TI
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt dff5288 
>   checker.h fcaac0b 
>   checker.cpp c4d1d0f 
>   issuemodel.h 7f09c8d 
>   issuemodel.cpp c63f065 
>   issuewidget.h 9bbadf2 
>   issuewidget.cpp bd68731 
>   kdevkrazy2.rc b12a325 
>   krazy2dialog.h 1133201 
>   krazy2dialog.cpp 6bb4d00 
>   krazy2plugin.h 2e09131 
>   krazy2plugin.cpp 2b79d3e 
>   krazy2view.h 3056e40 
>   krazy2view.cpp 851fbe0 
>   krazy2view.ui 9feab67 
>   selectcheckerswidget.h  
>   selectcheckerswidget.cpp 4afa804 
>   selectcheckerswidget.ui  
>   selectpathswidget.h 918455f 
>   selectpathswidget.cpp 12d1dce 
>   selectpathswidget.ui  
>   settings/krazy2projectsettings.h PRE-CREATION 
>   settings/krazy2projectsettings.cpp PRE-CREATION 
>   sortedissuesproxymodel.h d2bd9bc 
>   sortedissuesproxymodel.cpp a225b17 
>   tests/CMakeLists.txt 1ff43b9 
>   tests/issuemodeltest.cpp 3b8cf4e 
>   tests/issuewidgettest.cpp 699082d 
>   tests/krazy2viewtest.cpp d59f227 
>   tests/selectcheckerswidgettest.cpp a40a4ed 
>   tests/selectpathswidgettest.cpp d296ed5 
>   tests/sortedissuesproxymodeltest.cpp 0445341 
> 
> Diff: https://git.reviewboard.kde.org/r/124400/diff/
> 
> 
> Testing
> -------
> 
> * builds
> * works as intended according to my tests
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150720/5b898758/attachment.html>