<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124400/">https://git.reviewboard.kde.org/r/124400/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 lgtm.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BTW, +564 -6114 seems amazing.</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On July 20th, 2015, 3:45 p.m. CEST, Laszlo Kis-Adam wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Laszlo Kis-Adam.</div>
<p style="color: grey;"><i>Updated July 20, 2015, 3:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-krazy2
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Up until now the plugin used it's own toolview to set parameters, run krazy, and show issues. This patch moves the issues to a tab in the problems toolview, moves the settings to the project settings, and the tool can now be started from the run menu.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See video:
https://www.youtube.com/watch?v=gP81N07T5TI</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">builds</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">works as intended according to my tests</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(dff5288)</span></li>
<li>checker.h <span style="color: grey">(fcaac0b)</span></li>
<li>checker.cpp <span style="color: grey">(c4d1d0f)</span></li>
<li>issuemodel.h <span style="color: grey">(7f09c8d)</span></li>
<li>issuemodel.cpp <span style="color: grey">(c63f065)</span></li>
<li>issuewidget.h <span style="color: grey">(9bbadf2)</span></li>
<li>issuewidget.cpp <span style="color: grey">(bd68731)</span></li>
<li>kdevkrazy2.rc <span style="color: grey">(b12a325)</span></li>
<li>krazy2dialog.h <span style="color: grey">(1133201)</span></li>
<li>krazy2dialog.cpp <span style="color: grey">(6bb4d00)</span></li>
<li>krazy2plugin.h <span style="color: grey">(2e09131)</span></li>
<li>krazy2plugin.cpp <span style="color: grey">(2b79d3e)</span></li>
<li>krazy2view.h <span style="color: grey">(3056e40)</span></li>
<li>krazy2view.cpp <span style="color: grey">(851fbe0)</span></li>
<li>krazy2view.ui <span style="color: grey">(9feab67)</span></li>
<li>selectcheckerswidget.h <span style="color: grey">()</span></li>
<li>selectcheckerswidget.cpp <span style="color: grey">(4afa804)</span></li>
<li>selectcheckerswidget.ui <span style="color: grey">()</span></li>
<li>selectpathswidget.h <span style="color: grey">(918455f)</span></li>
<li>selectpathswidget.cpp <span style="color: grey">(12d1dce)</span></li>
<li>selectpathswidget.ui <span style="color: grey">()</span></li>
<li>settings/krazy2projectsettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>settings/krazy2projectsettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sortedissuesproxymodel.h <span style="color: grey">(d2bd9bc)</span></li>
<li>sortedissuesproxymodel.cpp <span style="color: grey">(a225b17)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(1ff43b9)</span></li>
<li>tests/issuemodeltest.cpp <span style="color: grey">(3b8cf4e)</span></li>
<li>tests/issuewidgettest.cpp <span style="color: grey">(699082d)</span></li>
<li>tests/krazy2viewtest.cpp <span style="color: grey">(d59f227)</span></li>
<li>tests/selectcheckerswidgettest.cpp <span style="color: grey">(a40a4ed)</span></li>
<li>tests/selectpathswidgettest.cpp <span style="color: grey">(d296ed5)</span></li>
<li>tests/sortedissuesproxymodeltest.cpp <span style="color: grey">(0445341)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124400/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>