Review Request 124330: Add parser arguments to custom defines/includes
Sergey Kalinichev
kalinichev.so.0 at gmail.com
Tue Jul 14 09:53:29 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124330/
-----------------------------------------------------------
(Updated July 14, 2015, 12:53 p.m.)
Review request for KDevelop.
Changes
-------
Reworked the GUI
Repository: kdevelop
Description
-------
This adds new tab to the before-mentioned plugin, with ability to set parser command-line arguments.
At first I didn't want to do it like that, but seems like it's the simplest/easiest way to implement it without duplicating much of the code.
That also means that even though the plugin is named custom defines/includes, now it also provides parser arguments, so I had to change "Custom defines/includes" title to "Language support".
Diffs (updated)
-----
languages/plugins/custom-definesandincludes/CMakeLists.txt 4c3d0dd
languages/plugins/custom-definesandincludes/compilerprovider/compilerfactories.cpp 766abc2
languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp ea0be28
languages/plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.h 235a1b8
languages/plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.cpp a9d82e1
languages/plugins/custom-definesandincludes/compilerprovider/icompiler.h f116b6f
languages/plugins/custom-definesandincludes/compilerprovider/icompiler.cpp 744ccb0
languages/plugins/custom-definesandincludes/compilerprovider/msvccompiler.h 488b759
languages/plugins/custom-definesandincludes/compilerprovider/msvccompiler.cpp f217386
languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.h a599492
languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp 66864c7
languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.cpp 8c0a75e
languages/plugins/custom-definesandincludes/definesandincludesmanager.h cd5a46e
languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp 8fd9178
languages/plugins/custom-definesandincludes/idefinesandincludesmanager.h 266986d
languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.cpp d1458c8
languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.ui 966677a
languages/plugins/custom-definesandincludes/kcm_widget/customdefinesandincludes.kcfg 97e3559
languages/plugins/custom-definesandincludes/kcm_widget/definesandincludesconfigpage.cpp cd9b60d
languages/plugins/custom-definesandincludes/kcm_widget/parserwidget.h PRE-CREATION
languages/plugins/custom-definesandincludes/kcm_widget/parserwidget.cpp PRE-CREATION
languages/plugins/custom-definesandincludes/kcm_widget/parserwidget.ui PRE-CREATION
languages/plugins/custom-definesandincludes/kcm_widget/projectpathsmodel.h 3c9baf1
languages/plugins/custom-definesandincludes/kcm_widget/projectpathsmodel.cpp 2b815f6
languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.h debf7ec
languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp 7126964
languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui 39470f0
Diff: https://git.reviewboard.kde.org/r/124330/diff/
Testing
-------
File Attachments (updated)
----------------
LanguageSupport2.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/14/8ae27d52-526c-4b0b-8241-cdb2ca06454e__LanguageSupport2.png
LanguageSupport3.png
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/14/cd938954-3c93-4e11-b716-962d7df2f9e9__LanguageSupport3.png
Thanks,
Sergey Kalinichev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150714/3a378339/attachment.html>
More information about the KDevelop-devel
mailing list