Review Request 124330: Add parser arguments to custom defines/includes

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124330/#review82425
-----------------------------------------------------------

Ship it!


I'd like to see some work on the GUI side, your approach is functional, but far from pretty I have to say. Either hide the lineedit below an advanced mode, or put radio buttons before the checkbox/lineedit and use that to enable/disable the items. Or maybe ask the VDG for input.


languages/plugins/custom-definesandincludes/compilerprovider/compilerfactories.cpp (line 44)
<https://git.reviewboard.kde.org/r/124330/#comment56809>

    reuse name() here



languages/plugins/custom-definesandincludes/compilerprovider/compilerfactories.cpp (line 62)
<https://git.reviewboard.kde.org/r/124330/#comment56810>

    same



languages/plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.cpp (line 45)
<https://git.reviewboard.kde.org/r/124330/#comment56811>

    please use QRegularExpression, it's much faster and its API is also nicer



languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp (line 53)
<https://git.reviewboard.kde.org/r/124330/#comment56812>

    wrap into functions please


- Milian Wolff


On July 12, 2015, 10:27 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124330/
> -----------------------------------------------------------
> 
> (Updated July 12, 2015, 10:27 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This adds new tab to the before-mentioned plugin, with ability to set parser command-line arguments.
> 
> At first I didn't want to do it like that, but seems like it's the simplest/easiest way to implement it without duplicating much of the code.
> That also means that even though the plugin is named custom defines/includes, now it also provides parser arguments, so I had to change "Custom defines/includes" title to "Language support".
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/CMakeLists.txt 4c3d0dd 
>   languages/plugins/custom-definesandincludes/compilerprovider/compilerfactories.cpp 766abc2 
>   languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp ea0be28 
>   languages/plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.h 235a1b8 
>   languages/plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.cpp a9d82e1 
>   languages/plugins/custom-definesandincludes/compilerprovider/icompiler.h f116b6f 
>   languages/plugins/custom-definesandincludes/compilerprovider/icompiler.cpp 744ccb0 
>   languages/plugins/custom-definesandincludes/compilerprovider/msvccompiler.h 488b759 
>   languages/plugins/custom-definesandincludes/compilerprovider/msvccompiler.cpp f217386 
>   languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.h a599492 
>   languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp 66864c7 
>   languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.cpp 8c0a75e 
>   languages/plugins/custom-definesandincludes/definesandincludesmanager.h cd5a46e 
>   languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp 8fd9178 
>   languages/plugins/custom-definesandincludes/idefinesandincludesmanager.h 266986d 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.cpp d1458c8 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.ui 966677a 
>   languages/plugins/custom-definesandincludes/kcm_widget/customdefinesandincludes.kcfg 97e3559 
>   languages/plugins/custom-definesandincludes/kcm_widget/definesandincludesconfigpage.cpp cd9b60d 
>   languages/plugins/custom-definesandincludes/kcm_widget/parserwidget.h PRE-CREATION 
>   languages/plugins/custom-definesandincludes/kcm_widget/parserwidget.cpp PRE-CREATION 
>   languages/plugins/custom-definesandincludes/kcm_widget/parserwidget.ui PRE-CREATION 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathsmodel.h 3c9baf1 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathsmodel.cpp 2b815f6 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.h debf7ec 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp 7126964 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui 39470f0 
> 
> Diff: https://git.reviewboard.kde.org/r/124330/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> LanguageSupport1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/12/a9af87f6-27fd-4c33-a18f-511ef3043c40__LanguageSupport1.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150712/f5c32162/attachment.html>