Review Request 124249: Greatly improve include-path completion performance

[Sergey Kalinichev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124249/
-----------------------------------------------------------

(Updated July 14, 2015, 9:40 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Changes
-------

Submitted with commit 4c3f5dcb465db4bfcce221011d353000ad2e4f24 by Sergey Kalinichev to branch master.


Repository: kdev-clang


Description
-------

Clang reparses a document without using PCH internally when editing file's preamble. This is very slow. So instead of locking ParseSession to prevent concurrent access to CXTranslationUnit (which include-path completion doesn't use), let's make ClangParsingEnvironment directly accessible through the session data.


Diffs
-----

  codecompletion/includepathcompletioncontext.cpp 34f613b 
  duchain/parsesession.h 74999de 
  duchain/parsesession.cpp cfafa33 

Diff: https://git.reviewboard.kde.org/r/124249/diff/


Testing
-------

I've been using this patch for more than a week. No side effects so far.


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150714/20b6900f/attachment.html>