Review Request 124249: Greatly improve include-path completion performance
Milian Wolff
mail at milianw.de
Sun Jul 12 20:40:20 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124249/#review82420
-----------------------------------------------------------
Ship it!
Ship It!
- Milian Wolff
On July 4, 2015, 9:45 a.m., Sergey Kalinichev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124249/
> -----------------------------------------------------------
>
> (Updated July 4, 2015, 9:45 a.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdev-clang
>
>
> Description
> -------
>
> Clang reparses a document without using PCH internally when editing file's preamble. This is very slow. So instead of locking ParseSession to prevent concurrent access to CXTranslationUnit (which include-path completion doesn't use), let's make ClangParsingEnvironment directly accessible through the session data.
>
>
> Diffs
> -----
>
> codecompletion/includepathcompletioncontext.cpp 34f613b
> duchain/parsesession.h 74999de
> duchain/parsesession.cpp cfafa33
>
> Diff: https://git.reviewboard.kde.org/r/124249/diff/
>
>
> Testing
> -------
>
> I've been using this patch for more than a week. No side effects so far.
>
>
> Thanks,
>
> Sergey Kalinichev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150712/18a83201/attachment.html>
More information about the KDevelop-devel
mailing list