Review Request 124242: Apply my KDevPlatform Problem API changes

[Aleix Pol Gonzalez]

> On July 3, 2015, 4:16 p.m., Milian Wolff wrote:
> > languages/cpp/cppduchain/cppduchain.cpp, line 431
> > <https://git.reviewboard.kde.org/r/124242/diff/2/?file=382783#file382783line431>
> >
> >     actually, all of this should probably be reverted in your patch - it's not related to the actual "IProblem" code you touched, no?
> 
> Laszlo Kis-Adam wrote:
>     Not related at all.
>     I pulled after you accidentally broke the build, so I had to fix it locally (in my local master branch).
>     No idea how it got in here even, especially since I ended up just reverting like you did. Probably forgot to reset some files.
>     I'll get rid of this soon.

Lol yeah... what was I thinking?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124242/#review82043
-----------------------------------------------------------


On July 3, 2015, 3:30 p.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124242/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 3:30 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> The patch simply applies my KDevPlatform Problem API changes. Diagnostics, Severity, Source...
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/contextbuilder.cpp 8aae468 
>   languages/cpp/cppduchain/cppduchain.cpp 9ec2eae 
>   languages/cpp/cppduchain/environmentmanager.cpp 21e2547 
>   languages/cpp/cppduchain/expressionvisitor.cpp 2a6c981 
>   languages/cpp/cppduchain/missingdeclarationproblem.cpp 48c6e25 
>   languages/cpp/cppduchain/usebuilder.cpp 2315694 
>   languages/cpp/cppparsejob.cpp 73da755 
>   languages/cpp/parser/commentformatter.cpp 5c53a83 
>   languages/cpp/parser/control.h d197558 
>   languages/cpp/parser/control.cpp 07e197d 
>   languages/cpp/parser/lexer.cpp 31130d3 
>   languages/cpp/parser/parser.h 933e2c8 
>   languages/cpp/parser/parser.cpp 8c74f61 
>   languages/cpp/parser/tests/test_parser.cpp b7cfbcf 
>   languages/cpp/preprocessjob.cpp a196c67 
> 
> Diff: https://git.reviewboard.kde.org/r/124242/diff/
> 
> 
> Testing
> -------
> 
> * Builds.
> * Based on my empirical studies, it works as intended.
> *
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150703/e8bb3cfe/attachment.html>