<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124242/">https://git.reviewboard.kde.org/r/124242/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 3rd, 2015, 4:16 p.m. CEST, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124242/diff/2/?file=382783#file382783line431" style="color: black; font-weight: bold; text-decoration: underline;">languages/cpp/cppduchain/cppduchain.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString preprocess( const QString& text, Cpp::EnvironmentFile* file, int line, QSet<IndexedString> disableMacros ) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">431</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="n">line</span> <span class="o">==</span> <span class="o">-</span><span class="mi">1</span> <span class="o">||</span> <span class="n">line</span> <span class="o">></span> <span class="n"><span class="hl">it</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">ref</span></span><span class="p"><span class="hl">(</span>).</span><span class="n">sourceLine</span> <span class="o">||</span> <span class="n">file</span><span class="o">-></span><span class="n">url</span><span class="p">()</span> <span class="o">!=</span> <span class="n"><span class="hl">it</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">ref</span></span><span class="p"><span class="hl">(</span>).</span><span class="n">file</span> <span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">431</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="n">line</span> <span class="o">==</span> <span class="o">-</span><span class="mi">1</span> <span class="o">||</span> <span class="n">line</span> <span class="o">></span> <span class="p"><span class="hl">(</span></span><span class="o"><span class="hl">*</span></span><span class="n"><span class="hl">it</span></span><span class="p">).</span><span class="n">sourceLine</span> <span class="o">||</span> <span class="n">file</span><span class="o">-></span><span class="n">url</span><span class="p">()</span> <span class="o">!=</span> <span class="p"><span class="hl">(</span></span><span class="o"><span class="hl">*</span></span><span class="n"><span class="hl">it</span></span><span class="p">).</span><span class="n">file</span> <span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">actually, all of this should probably be reverted in your patch - it's not related to the actual "IProblem" code you touched, no?</p></pre>
</blockquote>
<p>On July 3rd, 2015, 4:24 p.m. CEST, <b>Laszlo Kis-Adam</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not related at all.
I pulled after you accidentally broke the build, so I had to fix it locally (in my local master branch).
No idea how it got in here even, especially since I ended up just reverting like you did. Probably forgot to reset some files.
I'll get rid of this soon.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Lol yeah... what was I thinking?</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On July 3rd, 2015, 3:30 p.m. CEST, Laszlo Kis-Adam wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Laszlo Kis-Adam.</div>
<p style="color: grey;"><i>Updated July 3, 2015, 3:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch simply applies my KDevPlatform Problem API changes. Diagnostics, Severity, Source...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Builds.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Based on my empirical studies, it works as intended.
*</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/cppduchain/contextbuilder.cpp <span style="color: grey">(8aae468)</span></li>
<li>languages/cpp/cppduchain/cppduchain.cpp <span style="color: grey">(9ec2eae)</span></li>
<li>languages/cpp/cppduchain/environmentmanager.cpp <span style="color: grey">(21e2547)</span></li>
<li>languages/cpp/cppduchain/expressionvisitor.cpp <span style="color: grey">(2a6c981)</span></li>
<li>languages/cpp/cppduchain/missingdeclarationproblem.cpp <span style="color: grey">(48c6e25)</span></li>
<li>languages/cpp/cppduchain/usebuilder.cpp <span style="color: grey">(2315694)</span></li>
<li>languages/cpp/cppparsejob.cpp <span style="color: grey">(73da755)</span></li>
<li>languages/cpp/parser/commentformatter.cpp <span style="color: grey">(5c53a83)</span></li>
<li>languages/cpp/parser/control.h <span style="color: grey">(d197558)</span></li>
<li>languages/cpp/parser/control.cpp <span style="color: grey">(07e197d)</span></li>
<li>languages/cpp/parser/lexer.cpp <span style="color: grey">(31130d3)</span></li>
<li>languages/cpp/parser/parser.h <span style="color: grey">(933e2c8)</span></li>
<li>languages/cpp/parser/parser.cpp <span style="color: grey">(8c74f61)</span></li>
<li>languages/cpp/parser/tests/test_parser.cpp <span style="color: grey">(b7cfbcf)</span></li>
<li>languages/cpp/preprocessjob.cpp <span style="color: grey">(a196c67)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124242/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>