Review Request 124237: Remove ConvenientIterator::ref usage from oldcpp codebase.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124237/#review82023
-----------------------------------------------------------


TBH, I'm fine either way. Technically, it shouldn't make a difference whether we're using it as a reference or as a pointer, which makes me think we could be introducing a bug somewhere because we just changed the semantics, so if the tests pass, ship it.

Now, we should really be focusing in kdev-clang, as we're not going to fix oldcpp, ever.

- Aleix Pol Gonzalez


On July 3, 2015, 12:19 a.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124237/
> -----------------------------------------------------------
> 
> (Updated July 3, 2015, 12:19 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This requires some changes, as we cannot take the ptr address of
> the macro anymore. Instead, we use them as value classes everywhere.
> This may potentially degrade performance, but I don't have the time
> to measure it right now with a release build and compare the impact.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/cppduchain.cpp 9ec2eae62cfda472f5ebe3e2d92102df9bdad201 
>   languages/cpp/cppduchain/cpppreprocessenvironment.h 0d74f58ac44ec43134d5a4041863bef709e74ce3 
>   languages/cpp/cppduchain/cpppreprocessenvironment.cpp c99118cec7080a38814a86d92f744f6d441b2e5a 
>   languages/cpp/cppduchain/environmentmanager.h fe9743e8144fc9c822d7ec22290aa0a2fb469333 
>   languages/cpp/cppduchain/environmentmanager.cpp 21e2547253c9906c9c98da17648277ecd84df604 
>   languages/cpp/cppduchain/tests/test_environment.cpp f9002881523da8a65a43ab11f4b35c701149dfc2 
>   languages/cpp/cpplanguagesupport.h c4decfd237f6cd901dddb960520b480c64668216 
>   languages/cpp/cpplanguagesupport.cpp 282e1ff247d88247a9a7f29ab70d3ea45cf5be21 
>   languages/cpp/cppparsejob.cpp 73da7553bd714165ce676019a3bf5eb470d532a1 
>   languages/cpp/parser/rpp/pp-engine.cpp 0eb423119fc2abf1f9d82fb2fa963c32987426ce 
>   languages/cpp/parser/rpp/pp-environment.h 07e6dddeb4c7d5301870dbc206b9aa1673bb2c90 
>   languages/cpp/parser/rpp/pp-environment.cpp beabb71f400dea7db400c8233e7d7bc6aec45dc6 
>   languages/cpp/parser/rpp/pp-macro-expander.h b16b0c26f50b7984e6bcb283da1196d05a1d55fd 
>   languages/cpp/parser/rpp/pp-macro-expander.cpp 11867d451ee960c52f0ab1a5a42a49791a6f462d 
>   languages/cpp/parser/rpp/pp-macro.h 0e39b3f945324359173b11cb3a72ae24ffcb20dc 
>   languages/cpp/parser/rpp/pp-macro.cpp 1742dc4a1bab81831e24d1ee2842dc57145923fe 
> 
> Diff: https://git.reviewboard.kde.org/r/124237/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150702/a35abc00/attachment-0001.html>