<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124237/">https://git.reviewboard.kde.org/r/124237/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">TBH, I'm fine either way. Technically, it shouldn't make a difference whether we're using it as a reference or as a pointer, which makes me think we could be introducing a bug somewhere because we just changed the semantics, so if the tests pass, ship it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now, we should really be focusing in kdev-clang, as we're not going to fix oldcpp, ever.</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On July 3rd, 2015, 12:19 a.m. CEST, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated July 3, 2015, 12:19 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This requires some changes, as we cannot take the ptr address of
the macro anymore. Instead, we use them as value classes everywhere.
This may potentially degrade performance, but I don't have the time
to measure it right now with a release build and compare the impact.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/cppduchain/cppduchain.cpp <span style="color: grey">(9ec2eae62cfda472f5ebe3e2d92102df9bdad201)</span></li>
<li>languages/cpp/cppduchain/cpppreprocessenvironment.h <span style="color: grey">(0d74f58ac44ec43134d5a4041863bef709e74ce3)</span></li>
<li>languages/cpp/cppduchain/cpppreprocessenvironment.cpp <span style="color: grey">(c99118cec7080a38814a86d92f744f6d441b2e5a)</span></li>
<li>languages/cpp/cppduchain/environmentmanager.h <span style="color: grey">(fe9743e8144fc9c822d7ec22290aa0a2fb469333)</span></li>
<li>languages/cpp/cppduchain/environmentmanager.cpp <span style="color: grey">(21e2547253c9906c9c98da17648277ecd84df604)</span></li>
<li>languages/cpp/cppduchain/tests/test_environment.cpp <span style="color: grey">(f9002881523da8a65a43ab11f4b35c701149dfc2)</span></li>
<li>languages/cpp/cpplanguagesupport.h <span style="color: grey">(c4decfd237f6cd901dddb960520b480c64668216)</span></li>
<li>languages/cpp/cpplanguagesupport.cpp <span style="color: grey">(282e1ff247d88247a9a7f29ab70d3ea45cf5be21)</span></li>
<li>languages/cpp/cppparsejob.cpp <span style="color: grey">(73da7553bd714165ce676019a3bf5eb470d532a1)</span></li>
<li>languages/cpp/parser/rpp/pp-engine.cpp <span style="color: grey">(0eb423119fc2abf1f9d82fb2fa963c32987426ce)</span></li>
<li>languages/cpp/parser/rpp/pp-environment.h <span style="color: grey">(07e6dddeb4c7d5301870dbc206b9aa1673bb2c90)</span></li>
<li>languages/cpp/parser/rpp/pp-environment.cpp <span style="color: grey">(beabb71f400dea7db400c8233e7d7bc6aec45dc6)</span></li>
<li>languages/cpp/parser/rpp/pp-macro-expander.h <span style="color: grey">(b16b0c26f50b7984e6bcb283da1196d05a1d55fd)</span></li>
<li>languages/cpp/parser/rpp/pp-macro-expander.cpp <span style="color: grey">(11867d451ee960c52f0ab1a5a42a49791a6f462d)</span></li>
<li>languages/cpp/parser/rpp/pp-macro.h <span style="color: grey">(0e39b3f945324359173b11cb3a72ae24ffcb20dc)</span></li>
<li>languages/cpp/parser/rpp/pp-macro.cpp <span style="color: grey">(1742dc4a1bab81831e24d1ee2842dc57145923fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124237/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>