Review Request 122164: Cache custom includes in main thread

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122164/#review74385
-----------------------------------------------------------



pythonparsejob.cpp
<https://git.reviewboard.kde.org/r/122164/#comment51607>

    it's not really your fault, but this is still not threadsafe. I think Sven should really refacto the code to get rid of these statics to prevent race conditions and random parse errors.
    
    The Helper::cached* stuff should be removed altogether and instead the list be passed as function arguments along to wherever they are required.


- Milian Wolff


On Jan. 20, 2015, 12:40 p.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122164/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 12:40 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> Custom includes can't be obtained in the background thread, we must
> cache it from main thread.
> 
> 
> Diffs
> -----
> 
>   duchain/helpers.h d0212414a7c6dbf2a3bf251216632673d7fb32bd 
>   duchain/helpers.cpp a252d7cccac9aa1f563f5539060a071e88ced9c9 
>   pythonparsejob.h fa1b4a9a7840f9de895648bd384602a5c34a96cf 
>   pythonparsejob.cpp cc50eebfa3fd75817010ff70fcd4f621cbe89346 
>   CMakeLists.txt 648862017d0b5756628374b72643f42cb0ca1aa1 
>   duchain/CMakeLists.txt 2c876b40881b43224c888c1cbfe975213aca3f48 
> 
> Diff: https://git.reviewboard.kde.org/r/122164/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150120/1e3eb3e8/attachment.html>