<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122164/">https://git.reviewboard.kde.org/r/122164/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122164/diff/2/?file=343476#file343476line108" style="color: black; font-weight: bold; text-decoration: underline;">pythonparsejob.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ParseJob::run(ThreadWeaver::JobPointer self, ThreadWeaver::Thread* thread)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">108</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Helper</span><span class="o">::</span><span class="n">cachedCustomIncludes</span> <span class="o">=</span> <span class="n">m_cachedCustomIncludes</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it's not really your fault, but this is still not threadsafe. I think Sven should really refacto the code to get rid of these statics to prevent race conditions and random parse errors.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The Helper::cached* stuff should be removed altogether and instead the list be passed as function arguments along to wherever they are required.</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On January 20th, 2015, 12:40 p.m. UTC, Radek Novacek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Radek Novacek.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2015, 12:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-python
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Custom includes can't be obtained in the background thread, we must
cache it from main thread.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>duchain/helpers.h <span style="color: grey">(d0212414a7c6dbf2a3bf251216632673d7fb32bd)</span></li>
<li>duchain/helpers.cpp <span style="color: grey">(a252d7cccac9aa1f563f5539060a071e88ced9c9)</span></li>
<li>pythonparsejob.h <span style="color: grey">(fa1b4a9a7840f9de895648bd384602a5c34a96cf)</span></li>
<li>pythonparsejob.cpp <span style="color: grey">(cc50eebfa3fd75817010ff70fcd4f621cbe89346)</span></li>
<li>CMakeLists.txt <span style="color: grey">(648862017d0b5756628374b72643f42cb0ca1aa1)</span></li>
<li>duchain/CMakeLists.txt <span style="color: grey">(2c876b40881b43224c888c1cbfe975213aca3f48)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122164/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>