Review Request 122094: Ensure we don't assume that the TU-file is the file we are working on.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122094/
-----------------------------------------------------------

(Updated Jan. 19, 2015, 12:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Repository: kdev-clang


Description
-------

This is done by explicitly requesting a path to be passed to
ParseSession::file and adding ::mainFile with the old logic. This
probably will fix quite some potential issues, e.g. in the signature
assistant or code completion.

Furthermore, we should not triviall be able to share the parse session
between different contexts, if I'm not mistaken.


Diffs
-----

  codecompletion/includepathcompletioncontext.cpp 0334d110072f2cb0f46090b5e4343d15a43d7843 
  codecompletion/model.cpp 20eead41f992df85fbd193884642b3ab6d83cbbf 
  codegen/clangsignatureassistant.cpp 1241c74501b8e3459eac8ad0bc0ed49cec9bf43e 
  duchain/clangpch.cpp 61fee315a26aa93f3cd158c6834b5bc09e62e388 
  duchain/debugvisitor.h 870562f758171c1226b5f35005c879a8a8f2a402 
  duchain/debugvisitor.cpp be8debffacb88ee238be8f6d7a3087bf6f75ebcd 
  duchain/parsesession.h 6cf0dea8e53a9c6fb35a37e1778eac78f273d0d4 
  duchain/parsesession.cpp a30422bea258f25c8939fbe4824490c312fba969 
  tests/clang-parser.cpp 6f74799036a44c242195de067bba7f6618af1871 
  tests/test_codecompletion.cpp 1ef9228079ae74b347eaa8ad4614d5c02d8a7771 
  tests/test_problems.cpp 64f6e65005b57be4190770df1c5ae1b8427cf80d 
  clangparsejob.cpp 21c71b8eaae19b633349f9245cee44e56d7783e7 
  codecompletion/completionhelper.h 6e05e4546c23b0314ff9025d356a4f6c0d94fd59 
  codecompletion/completionhelper.cpp f5ed2b9d061ed8ef6d96f4ce534d5267fcd9dcb1 
  codecompletion/context.h 9c55eadafa0bed8fd16626ecde7ed8eb40f423e4 
  codecompletion/context.cpp bea744fe05cab5ddf7711312b0d9b6d6083bd4bd 
  codecompletion/includepathcompletioncontext.h 2bf1c4ad593d5c5640d45fae73ebe815ef97aa90 

Diff: https://git.reviewboard.kde.org/r/122094/diff/


Testing
-------


Thanks,

Milian Wolff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150119/d39e1f83/attachment.html>