<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122094/">https://git.reviewboard.kde.org/r/122094/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2015, 12:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is done by explicitly requesting a path to be passed to
ParseSession::file and adding ::mainFile with the old logic. This
probably will fix quite some potential issues, e.g. in the signature
assistant or code completion.
Furthermore, we should not triviall be able to share the parse session
between different contexts, if I'm not mistaken.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>codecompletion/includepathcompletioncontext.cpp <span style="color: grey">(0334d110072f2cb0f46090b5e4343d15a43d7843)</span></li>
<li>codecompletion/model.cpp <span style="color: grey">(20eead41f992df85fbd193884642b3ab6d83cbbf)</span></li>
<li>codegen/clangsignatureassistant.cpp <span style="color: grey">(1241c74501b8e3459eac8ad0bc0ed49cec9bf43e)</span></li>
<li>duchain/clangpch.cpp <span style="color: grey">(61fee315a26aa93f3cd158c6834b5bc09e62e388)</span></li>
<li>duchain/debugvisitor.h <span style="color: grey">(870562f758171c1226b5f35005c879a8a8f2a402)</span></li>
<li>duchain/debugvisitor.cpp <span style="color: grey">(be8debffacb88ee238be8f6d7a3087bf6f75ebcd)</span></li>
<li>duchain/parsesession.h <span style="color: grey">(6cf0dea8e53a9c6fb35a37e1778eac78f273d0d4)</span></li>
<li>duchain/parsesession.cpp <span style="color: grey">(a30422bea258f25c8939fbe4824490c312fba969)</span></li>
<li>tests/clang-parser.cpp <span style="color: grey">(6f74799036a44c242195de067bba7f6618af1871)</span></li>
<li>tests/test_codecompletion.cpp <span style="color: grey">(1ef9228079ae74b347eaa8ad4614d5c02d8a7771)</span></li>
<li>tests/test_problems.cpp <span style="color: grey">(64f6e65005b57be4190770df1c5ae1b8427cf80d)</span></li>
<li>clangparsejob.cpp <span style="color: grey">(21c71b8eaae19b633349f9245cee44e56d7783e7)</span></li>
<li>codecompletion/completionhelper.h <span style="color: grey">(6e05e4546c23b0314ff9025d356a4f6c0d94fd59)</span></li>
<li>codecompletion/completionhelper.cpp <span style="color: grey">(f5ed2b9d061ed8ef6d96f4ce534d5267fcd9dcb1)</span></li>
<li>codecompletion/context.h <span style="color: grey">(9c55eadafa0bed8fd16626ecde7ed8eb40f423e4)</span></li>
<li>codecompletion/context.cpp <span style="color: grey">(bea744fe05cab5ddf7711312b0d9b6d6083bd4bd)</span></li>
<li>codecompletion/includepathcompletioncontext.h <span style="color: grey">(2bf1c4ad593d5c5640d45fae73ebe815ef97aa90)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122094/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>