Review Request 122066: WIP: Track all unsaved documents and pass them to clang.

[Sergey Kalinichev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122066/#review74056
-----------------------------------------------------------



duchain/parsesession.h
<https://git.reviewboard.kde.org/r/122066/#comment51422>

    The comments should be changed too



duchain/unsavedfile.cpp
<https://git.reviewboard.kde.org/r/122066/#comment51423>

    clangDebug ?


>But, bigger an issue, is that you now easily get highlighting errors, e.g. when adding a line the ranges are not properly moving as they are supposed to. 

Though I didn't test it much, but I couldn't reproduce that. The only issue I had is completely wrong highlighting when I opened a project. But clearing the duchain cache solved the problem.

- Sergey Kalinichev


On Jan. 15, 2015, 5:05 a.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122066/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 5:05 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This has still some issues, like tests not yet ported. But, bigger
> an issue, is that you now easily get highlighting errors, e.g.
> when adding a line the ranges are not properly moving as they are
> supposed to. I haven't had time to investigate this yet.
> 
> 
> Diffs
> -----
> 
>   clangparsejob.h 1cc8282299a87900cd4cab8699d81a37f978983b 
>   clangparsejob.cpp a72753da2caef7e7fc6e03912c261440ec1d16fc 
>   duchain/CMakeLists.txt 72464a5ec30e1f0ea0bc61139e40ff6ab905cc99 
>   duchain/clangpch.cpp 6ad2b9e11220ee293c9e5cca01fa256be34c12c9 
>   duchain/parsesession.h 84dccae2b4cd266f438cd75fecf1895277a16206 
>   duchain/parsesession.cpp 02daf9cf29dc58a067da71a7f228f96985e856b8 
>   duchain/unsavedfile.h PRE-CREATION 
>   duchain/unsavedfile.cpp PRE-CREATION 
>   tests/clang-parser.cpp 3f87d053e8f6c92e9870760d320f5de1cebc5cd3 
>   tests/test_problems.cpp 39377823aeede0ec318ac48daf2f9dbeb408a95c 
> 
> Diff: https://git.reviewboard.kde.org/r/122066/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150115/5b880cfe/attachment.html>