<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122066/">https://git.reviewboard.kde.org/r/122066/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122066/diff/1/?file=341962#file341962line69" style="color: black; font-weight: bold; text-decoration: underline;">duchain/parsesession.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * @param sessionContents The contents of the document you want to parse</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">66</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * @param sessionContents The contents of the document you want to parse</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The comments should be changed too</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122066/diff/1/?file=341965#file341965line47" style="color: black; font-weight: bold; text-decoration: underline;">duchain/unsavedfile.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">47</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qDebug</span><span class="p">()</span> <span class="o"><<</span> <span class="s">"GOT:"</span> <span class="o"><<</span> <span class="n">m_fileNameUtf8</span> <span class="o"><<</span> <span class="n">m_contentsUtf8</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">clangDebug ?</p></pre>
</div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But, bigger an issue, is that you now easily get highlighting errors, e.g. when adding a line the ranges are not properly moving as they are supposed to. </p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Though I didn't test it much, but I couldn't reproduce that. The only issue I had is completely wrong highlighting when I opened a project. But clearing the duchain cache solved the problem.</p></pre>
<p>- Sergey Kalinichev</p>
<br />
<p>On January 15th, 2015, 5:05 a.m. MSK, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2015, 5:05 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This has still some issues, like tests not yet ported. But, bigger
an issue, is that you now easily get highlighting errors, e.g.
when adding a line the ranges are not properly moving as they are
supposed to. I haven't had time to investigate this yet.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>clangparsejob.h <span style="color: grey">(1cc8282299a87900cd4cab8699d81a37f978983b)</span></li>
<li>clangparsejob.cpp <span style="color: grey">(a72753da2caef7e7fc6e03912c261440ec1d16fc)</span></li>
<li>duchain/CMakeLists.txt <span style="color: grey">(72464a5ec30e1f0ea0bc61139e40ff6ab905cc99)</span></li>
<li>duchain/clangpch.cpp <span style="color: grey">(6ad2b9e11220ee293c9e5cca01fa256be34c12c9)</span></li>
<li>duchain/parsesession.h <span style="color: grey">(84dccae2b4cd266f438cd75fecf1895277a16206)</span></li>
<li>duchain/parsesession.cpp <span style="color: grey">(02daf9cf29dc58a067da71a7f228f96985e856b8)</span></li>
<li>duchain/unsavedfile.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>duchain/unsavedfile.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/clang-parser.cpp <span style="color: grey">(3f87d053e8f6c92e9870760d320f5de1cebc5cd3)</span></li>
<li>tests/test_problems.cpp <span style="color: grey">(39377823aeede0ec318ac48daf2f9dbeb408a95c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122066/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>