Review Request 121629: Port to .json from .desktop meta data file.

Milian Wolff mail at milianw.de
Mon Jan 12 11:38:09 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121629/#review73593
-----------------------------------------------------------



documentfinderhelpers.cpp
<https://git.reviewboard.kde.org/r/121629/#comment51244>

    I've added a TODO, but it's not so simple to implement. Most notably, this is called from the ctor of the clangsupport, i.e. the controllers don't know it yet. thus its hard to get to KPluginMetaData. Otherwise, one could just query the plugin, get its info, and read the X-KDevelop-SupportedMimeTypes. I'm reluctant to duplicate the code to find the plugin path here just for this list...


- Milian Wolff


On Jan. 9, 2015, 2:07 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121629/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 2:07 p.m.)
> 
> 
> Review request for KDevelop and Burkhard Lück.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Port to .json from .desktop meta data file.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 98ac12487ca7219e36c5ef5ea2ef06f4e2bd089c 
>   clangsupport.cpp 43f5306a2f994f207fcec90c76241ecbd1cdbcb5 
>   documentfinderhelpers.h 05eaceb278195e192d2320d02e8fe87add69164d 
>   documentfinderhelpers.cpp 2cdcbe690597648b864241dad74b6268c73cb94e 
>   kdevclangsupport.desktop.cmake ad186bd17f90f6557f380cbe268de6db58485ea4 
>   kdevclangsupport.json PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121629/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150112/e7cd96c7/attachment.html>


More information about the KDevelop-devel mailing list