<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121629/">https://git.reviewboard.kde.org/r/121629/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121629/diff/3/?file=335364#file335364line212" style="color: black; font-weight: bold; text-decoration: underline;">documentfinderhelpers.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QPair<QString,FileType> basePathAndTypeForUrl(const QUrl &url)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">212</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KDesktopFile</span> <span class="n">desktopFile</span><span class="p">(</span><span class="n">QStandardPaths</span><span class="o">::</span><span class="n">GenericDataLocation</span><span class="p">,</span> <span class="n">QString</span><span class="p">(</span><span class="s">"kservices5/kdevclangsupport.desktop"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">212</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">static</span> <span class="k">const</span> <span class="n">QStringList</span> <span class="n">mimeTypes</span> <span class="o">=</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've added a TODO, but it's not so simple to implement. Most notably, this is called from the ctor of the clangsupport, i.e. the controllers don't know it yet. thus its hard to get to KPluginMetaData. Otherwise, one could just query the plugin, get its info, and read the X-KDevelop-SupportedMimeTypes. I'm reluctant to duplicate the code to find the plugin path here just for this list...</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On January 9th, 2015, 2:07 p.m. UTC, Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Burkhard Lück.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2015, 2:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port to .json from .desktop meta data file.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(98ac12487ca7219e36c5ef5ea2ef06f4e2bd089c)</span></li>
<li>clangsupport.cpp <span style="color: grey">(43f5306a2f994f207fcec90c76241ecbd1cdbcb5)</span></li>
<li>documentfinderhelpers.h <span style="color: grey">(05eaceb278195e192d2320d02e8fe87add69164d)</span></li>
<li>documentfinderhelpers.cpp <span style="color: grey">(2cdcbe690597648b864241dad74b6268c73cb94e)</span></li>
<li>kdevclangsupport.desktop.cmake <span style="color: grey">(ad186bd17f90f6557f380cbe268de6db58485ea4)</span></li>
<li>kdevclangsupport.json <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121629/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>