Review Request 121989: Correctly build imported contexts for nested imports

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121989/#review73823
-----------------------------------------------------------

Ship it!


the style nitpick from nicolai can be improved in a separate commit later on. if you like, I can also do that then.


tests/test_duchain.cpp
<https://git.reviewboard.kde.org/r/121989/#comment51345>

    could you also verify that the correct files are imported? i.e. that A includes B and C and that C includes B? Also, please verify that B does not import anything.


- Milian Wolff


On Jan. 11, 2015, 3:10 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121989/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2015, 3:10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> It should resolve most (all?) of the problems with missing imports. The problem was: File A includes B, C. C includes B. When parsing, imports were corretly added to A, but not to C.
> 
> 
> Diffs
> -----
> 
>   duchain/clanghelpers.cpp 9c7ade4 
>   tests/test_duchain.h 22535cf 
>   tests/test_duchain.cpp 735c001 
> 
> Diff: https://git.reviewboard.kde.org/r/121989/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150112/78e3a9f7/attachment.html>