Review Request 121989: Correctly build imported contexts for nested imports
Kevin Funk
kfunk at kde.org
Sun Jan 11 16:35:33 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121989/#review73760
-----------------------------------------------------------
Ship it!
Makes sense to me.
- Kevin Funk
On Jan. 11, 2015, 3:10 p.m., Sergey Kalinichev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121989/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2015, 3:10 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdev-clang
>
>
> Description
> -------
>
> It should resolve most (all?) of the problems with missing imports. The problem was: File A includes B, C. C includes B. When parsing, imports were corretly added to A, but not to C.
>
>
> Diffs
> -----
>
> duchain/clanghelpers.cpp 9c7ade4
> tests/test_duchain.h 22535cf
> tests/test_duchain.cpp 735c001
>
> Diff: https://git.reviewboard.kde.org/r/121989/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Kalinichev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150111/a8c9d920/attachment.html>
More information about the KDevelop-devel
mailing list