Review Request 121964: Make the BranchesListModel public
Kevin Funk
kfunk at kde.org
Sun Jan 11 16:33:44 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121964/#review73759
-----------------------------------------------------------
Ship it!
It's already used inside the welcomepage plugin, so it makes sense to make it public => Go for it
vcs/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121964/#comment51326>
Shouldn't be needed.
But I can see the problem you're trying to fix. Please do a `#include <vcs/vcsexport.h>` in `brancheslistmodel.h` instead.
vcs/models/brancheslistmodel.cpp
<https://git.reviewboard.kde.org/r/121964/#comment51324>
Style: Newline before `{`
vcs/models/brancheslistmodel.cpp
<https://git.reviewboard.kde.org/r/121964/#comment51325>
Style: Remove empty line
- Kevin Funk
On Jan. 10, 2015, 11:44 a.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121964/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2015, 11:44 a.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> Currently the header file of BranchesListModel isn't being installed, but from the code
> it seems that the intetion was to offer BranchesListModel as a public class.
>
> This patch changes this behaviour by installing the header file of BranchesListModel and
> also the class is now using a d-pointer.
>
>
> Diffs
> -----
>
> vcs/CMakeLists.txt 1376bc8
> vcs/models/brancheslistmodel.h 66ead9e
> vcs/models/brancheslistmodel.cpp 03d3d3b
>
> Diff: https://git.reviewboard.kde.org/r/121964/diff/
>
>
> Testing
> -------
>
> a. create a new project with plasmate
> b. create a new branch
> c. switch to the new branch
>
> it worked.
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150111/23a45022/attachment-0001.html>
More information about the KDevelop-devel
mailing list