Review Request 121964: Make the BranchesListModel public

[Nicolai Hähnle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121964/#review73750
-----------------------------------------------------------


Dear Giorgios, I cannot really comment on the intended design of this code, but I did notice a bug, see below.

Is there a particular reason why you want this class to be exported? All else equal, a smaller exported interface surface is better.


vcs/models/brancheslistmodel.h
<https://git.reviewboard.kde.org/r/121964/#comment51321>

    This is never freed ATM.
    
    Turn this into a std::unique_ptr. (Note that this requires you to add an empty destructor to the .cpp file.)


- Nicolai Hähnle


On Jan. 10, 2015, 11:44 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121964/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2015, 11:44 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Currently the header file of BranchesListModel isn't being installed, but from the code
> it seems that the intetion was to offer BranchesListModel as a public class.
> 
> This patch changes this behaviour by installing the header file of BranchesListModel and 
> also the class is now using a d-pointer.
> 
> 
> Diffs
> -----
> 
>   vcs/CMakeLists.txt 1376bc8 
>   vcs/models/brancheslistmodel.h 66ead9e 
>   vcs/models/brancheslistmodel.cpp 03d3d3b 
> 
> Diff: https://git.reviewboard.kde.org/r/121964/diff/
> 
> 
> Testing
> -------
> 
> a. create a new project with plasmate
> b. create a new branch
> c. switch to the new branch
> 
> it worked.
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150111/b9149576/attachment.html>