Review Request 121808: Add IBSM::hasIncludesOrDefines

[Olivier Jean de Gaalon]

> On Jan. 5, 2015, 12:19 a.m., Aleix Pol Gonzalez wrote:
> > project/interfaces/ibuildsystemmanager.h, line 117
> > <https://git.reviewboard.kde.org/r/121808/diff/2/?file=338110#file338110line117>
> >
> >     Sorry for the nitpicking, but should we call it isFileManaged(ProjectFileItem* item)?
> 
> Milian Wolff wrote:
>     I don't find that particularly helpful. The current name is explicit in what it checks. I mean, an "unmanaged" file wouldn't have a ProjectBaseItem associated, would it? :)
> 
> Aleix Pol Gonzalez wrote:
>     Well, it's clearly the case. These are unmanaged files, we added them to the project model for practical use, but not because of data/view layers separation.
>     
>     I don't hate hasIncludesOrDefines, it just gives me bad vibrations. Feel free to commit and keep working on more interesting things. :)

I don't love hasIncludesOrDefines, but I don't really like isFileManaged either. I considered hasBuildSystemInfo, but that's really too general and the definition of that might change with IBSM changes in scope. The question we really want an answer to really is hasIncludesOrDefines, afaict.

I'll wait until tomorrow to give time for additional naming thoughts.


- Olivier Jean de


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121808/#review73101
-----------------------------------------------------------


On Jan. 4, 2015, 12:07 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121808/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2015, 12:07 p.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez and Milian Wolff.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> IBSM::hasIncludesOrDefines is needed to check whether a given file has information from the buildsystem.
> 
> 
> Diffs
> -----
> 
>   project/interfaces/ibuildsystemmanager.h 2be2c43 
> 
> Diff: https://git.reviewboard.kde.org/r/121808/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150105/a0e6d84b/attachment.html>