Review Request 121808: Add IBSM::hasIncludesOrDefines

[Aleix Pol Gonzalez]

> On Jan. 5, 2015, 12:19 a.m., Aleix Pol Gonzalez wrote:
> > project/interfaces/ibuildsystemmanager.h, line 117
> > <https://git.reviewboard.kde.org/r/121808/diff/2/?file=338110#file338110line117>
> >
> >     Sorry for the nitpicking, but should we call it isFileManaged(ProjectFileItem* item)?
> 
> Milian Wolff wrote:
>     I don't find that particularly helpful. The current name is explicit in what it checks. I mean, an "unmanaged" file wouldn't have a ProjectBaseItem associated, would it? :)

Well, it's clearly the case. These are unmanaged files, we added them to the project model for practical use, but not because of data/view layers separation.

I don't hate hasIncludesOrDefines, it just gives me bad vibrations. Feel free to commit and keep working on more interesting things. :)


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121808/#review73101
-----------------------------------------------------------


On Jan. 4, 2015, 12:07 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121808/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2015, 12:07 p.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez and Milian Wolff.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> IBSM::hasIncludesOrDefines is needed to check whether a given file has information from the buildsystem.
> 
> 
> Diffs
> -----
> 
>   project/interfaces/ibuildsystemmanager.h 2be2c43 
> 
> Diff: https://git.reviewboard.kde.org/r/121808/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150105/a4136009/attachment.html>