Review Request 121794: BreakpointModel: load and save from session instead of from global configuration

[Nicolai Hähnle]

> On Jan. 3, 2015, 4:10 nachm., Aleix Pol Gonzalez wrote:
> > debugger/breakpoint/breakpointmodel.h, line 193
> > <https://git.reviewboard.kde.org/r/121794/diff/1/?file=337810#file337810line193>
> >
> >     KConfig already keeps track of whether it's dirty, maybe it should be enough?
> >     
> >     If so all those scheduleSave shouldn't be needed. In fact, it seems you're workarounding another bug here, no?

The intention here is to avoid duplicate work. Consider, for example, what happens when a manually added breakpoint is received from GDB. The GDB plugin will create the breakpoint and then update its location and possibly other attributes. The idea is that those changes get batched into a single run of `BreakpointModel::save()`. Perhaps there's a better way to do this, and if so I'd be interested to learn how.


- Nicolai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121794/#review73028
-----------------------------------------------------------


On Jan. 2, 2015, 8:52 nachm., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121794/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, 8:52 nachm.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> BUG: 336773
> 
> 
> Diffs
> -----
> 
>   debugger/breakpoint/breakpointmodel.h afab32b9850fc0942bf15fd45dbc82814350e182 
>   debugger/breakpoint/breakpointmodel.cpp 360bb2fa69b85c696bdd6acc02362b317911d1f9 
>   shell/debugcontroller.cpp 823d3c8ff752539d1ad0e2b57c4f614235699eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/121794/diff/
> 
> 
> Testing
> -------
> 
> manual testing
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150103/23268684/attachment-0001.html>