Review Request 121794: BreakpointModel: load and save from session instead of from global configuration

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121794/#review73028
-----------------------------------------------------------


This really bothered me for a long time, thanks for looking into this!


debugger/breakpoint/breakpointmodel.h
<https://git.reviewboard.kde.org/r/121794/#comment50814>

    KConfig already keeps track of whether it's dirty, maybe it should be enough?
    
    If so all those scheduleSave shouldn't be needed. In fact, it seems you're workarounding another bug here, no?


- Aleix Pol Gonzalez


On Jan. 2, 2015, 8:52 p.m., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121794/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, 8:52 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> BUG: 336773
> 
> 
> Diffs
> -----
> 
>   debugger/breakpoint/breakpointmodel.h afab32b9850fc0942bf15fd45dbc82814350e182 
>   debugger/breakpoint/breakpointmodel.cpp 360bb2fa69b85c696bdd6acc02362b317911d1f9 
>   shell/debugcontroller.cpp 823d3c8ff752539d1ad0e2b57c4f614235699eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/121794/diff/
> 
> 
> Testing
> -------
> 
> manual testing
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150103/d8884560/attachment.html>