Review Request 122388: Custom Build System human readable defines and include search path for KDevelop kf5/master

Salamander Purake salamanderrake at gmail.com
Fri Feb 27 17:21:28 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122388/
-----------------------------------------------------------

(Updated Feb. 27, 2015, 5:21 p.m.)


Review request for KDevelop.


Changes
-------

Put Settings new and backwards compilers and another entry in to a free function in an empty namespace per Sergey's request.


Repository: kdevelop


Description
-------

Made the defines and include path lists human readable by removing the QDataStream and QByte types from the save load steps.


Diffs (updated)
-----

  projectmanagers/custom-buildsystem/kcm_kdevcustombuildsystem.desktop.cmake d0e9e8f 
  languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.cpp f9fb7fe 
  languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.h e92ebc0 
  languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp df2c425 

Diff: https://git.reviewboard.kde.org/r/122388/diff/


Testing
-------

create/load a custom build system project (${project-name}.kdev4) add defines and includes path to project via in the text file and the dialog. Tested the defines lines inside the source code files and the autocompletion also in the code files.


Thanks,

Salamander Purake

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150227/86dc15b1/attachment.html>


More information about the KDevelop-devel mailing list