Review Request 122388: Custom Build System human readable defines and include search path for KDevelop kf5/master

[Salamander Purake]

> On Feb. 21, 2015, 8:47 a.m., Sergey Kalinichev wrote:
> > languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp, line 221
> > <https://git.reviewboard.kde.org/r/122388/diff/6/?file=350220#file350220line221>
> >
> >     This is a namespace closing brace. Why did you remove it? Does it even compile?

Yeah strangely it did compile but shouldn't have.


- Salamander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122388/#review76361
-----------------------------------------------------------


On Feb. 22, 2015, 5:25 a.m., Salamander Purake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122388/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2015, 5:25 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Made the defines and include path lists human readable by removing the QDataStream and QByte types from the save load steps.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp df2c425 
>   languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.h e92ebc0 
>   languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.cpp f9fb7fe 
> 
> Diff: https://git.reviewboard.kde.org/r/122388/diff/
> 
> 
> Testing
> -------
> 
> create/load a custom build system project (${project-name}.kdev4) add defines and includes path to project via in the text file and the dialog. Tested the defines lines inside the source code files and the autocompletion also in the code files.
> 
> 
> Thanks,
> 
> Salamander Purake
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150222/3e20fbaf/attachment-0001.html>