Review Request 122388: Custom Build System human readable defines and include search path for KDevelop 4.7

[Salamander Purake]

> On Feb. 13, 2015, 8:03 a.m., Sergey Kalinichev wrote:
> > languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp, line 99
> > <https://git.reviewboard.kde.org/r/122388/diff/3/?file=348168#file348168line99>
> >
> >     What if you have settings in the old format, then add another config entry in the new format?
> >     You don't remove the settings in the old format. So, on subsequent readings, the settings in the new format will be ignored.
> >     To resolve this you should remove the old settings (see also the remove option and the convertedPaths function).

If you mean by adding an entry to an old format .kdev4/$ProjectName.kdev4 from within KDevelop, thats a moot point since when you save the whole thing is rewritten to the new format anyways and the added entry is not ignored. If no entries are added or removed then the config is unchanged it will still keep reading it in the old format until they decide to change a setting. Here is a test project with multiple paths and a config with mixed entries, one old format and ane new format. https://dl.dropboxusercontent.com/u/71062164/unrealengine/KDevelop/compat.tar.bz2
With my patch it will keep reading the config as it is without issue until someting is changed internally. If you somehow find a way to break it please let me know and tell me what you did, also I don't know if it will build, the compat2 level as there is on compat2.kdev4 file in there to tell it how to compile.


- Salamander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122388/#review75970
-----------------------------------------------------------


On Feb. 9, 2015, 10:56 p.m., Salamander Purake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122388/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2015, 10:56 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Made the defines and include path lists human readable by removing the QDataStream and QByte types from the save load steps.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp bcdebe5 
> 
> Diff: https://git.reviewboard.kde.org/r/122388/diff/
> 
> 
> Testing
> -------
> 
> create/load a custom build system project (${project-name}.kdev4) add defines and includes path to project via in the text file and the dialog. Tested the defines lines inside the source code files and the autocompletion also in the code files.
> 
> 
> Thanks,
> 
> Salamander Purake
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150213/b4230aa1/attachment.html>