Review Request 122388: Custom Build System human readable defines and include search path for KDevelop 4.7

[Sergey Kalinichev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122388/#review75970
-----------------------------------------------------------



languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp
<https://git.reviewboard.kde.org/r/122388/#comment52410>

    Once again, please, bring it back



languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp
<https://git.reviewboard.kde.org/r/122388/#comment52413>

    What if you have settings in the old format, then add another config entry in the new format?
    You don't remove the settings in the old format. So, on subsequent readings, the settings in the new format will be ignored.
    To resolve this you should remove the old settings (see also the remove option and the convertedPaths function).



languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp
<https://git.reviewboard.kde.org/r/122388/#comment52412>

    You don't need the value here. Remove it and use it.value() below.



languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp
<https://git.reviewboard.kde.org/r/122388/#comment52411>

    Here and everywhere else use isEmpty() instead.


- Sergey Kalinichev


On Feb. 10, 2015, 2:56 a.m., Salamander Purake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122388/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2015, 2:56 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Made the defines and include path lists human readable by removing the QDataStream and QByte types from the save load steps.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp bcdebe5 
> 
> Diff: https://git.reviewboard.kde.org/r/122388/diff/
> 
> 
> Testing
> -------
> 
> create/load a custom build system project (${project-name}.kdev4) add defines and includes path to project via in the text file and the dialog. Tested the defines lines inside the source code files and the autocompletion also in the code files.
> 
> 
> Thanks,
> 
> Salamander Purake
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150213/51679b05/attachment.html>