Review Request 122398: Actions QuickOpen backend

[Aleix Pol Gonzalez]

> On Feb. 3, 2015, 4:42 p.m., Kevin Funk wrote:
> > plugins/quickopen/actionsquickopenprovider.cpp, line 79
> > <https://git.reviewboard.kde.org/r/122398/diff/2/?file=346602#file346602line79>
> >
> >     Use `foreach` on Qt containers, otherwise they're detached -- see http://blog.qt.digia.com/blog/2011/05/26/cpp0x-in-qt/ ('range-based for')

Good catch! I made the collections const.


> On Feb. 3, 2015, 4:42 p.m., Kevin Funk wrote:
> > plugins/quickopen/quickopenplugin.cpp, line 838
> > <https://git.reviewboard.kde.org/r/122398/diff/2/?file=346604#file346604line838>
> >
> >     My biggest issue with this patch: The scope filter doesn't really fit for this new provider. Do you already have plans how to deal with that in the UI?

Yes, I'm planning to sit all together soon enough and figure the shit out of it. Or think deeply [1].

[1] thinking very deeply https://www.youtube.com/watch?v=p4SXWHPpKRQ


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122398/#review75314
-----------------------------------------------------------


On Feb. 3, 2015, 1:53 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122398/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 1:53 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> I wanted to look into this for longtime, only ended up doing so yesterday when flying home from FOSDEM.
> 
> The idea is simple, we love Quick Open, we get actions on the Quick Open.
> I see it as an approach to what Milian wanted to look into, of having a console to run KDevelop, I think that this with some development could end up quite close. For now, it's already somewhat useful.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/CMakeLists.txt 90e1efd 
>   plugins/quickopen/actionsquickopenprovider.h PRE-CREATION 
>   plugins/quickopen/actionsquickopenprovider.cpp PRE-CREATION 
>   plugins/quickopen/quickopenplugin.h 829e0ab 
>   plugins/quickopen/quickopenplugin.cpp 75ee422 
> 
> Diff: https://git.reviewboard.kde.org/r/122398/diff/
> 
> 
> Testing
> -------
> 
> I played around with it for a while.
> 
> 
> File Attachments
> ----------------
> 
> quickopen-actions.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/b94711e0-837b-42a1-bbee-75b42b797cd9__quickopen-actions.png
> quickopen-actions1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/5665a6bd-7df6-4121-89ab-c12c4a0ebf30__quickopen-actions1.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150204/d449857c/attachment.html>