Review Request 122398: Actions QuickOpen backend

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122398/#review75314
-----------------------------------------------------------


Generally looks okay to me, this would be a nice addition.


plugins/quickopen/actionsquickopenprovider.cpp
<https://git.reviewboard.kde.org/r/122398/#comment52097>

    Raw pointer is fine here, since you don't expect it to be deleted anyway.



plugins/quickopen/actionsquickopenprovider.cpp
<https://git.reviewboard.kde.org/r/122398/#comment52099>

    Style: Space after keywords (more below).



plugins/quickopen/actionsquickopenprovider.cpp
<https://git.reviewboard.kde.org/r/122398/#comment52098>

    Use `foreach` on Qt containers, otherwise they're detached -- see http://blog.qt.digia.com/blog/2011/05/26/cpp0x-in-qt/ ('range-based for')



plugins/quickopen/quickopenplugin.cpp
<https://git.reviewboard.kde.org/r/122398/#comment52100>

    My biggest issue with this patch: The scope filter doesn't really fit for this new provider. Do you already have plans how to deal with that in the UI?


- Kevin Funk


On Feb. 3, 2015, 12:53 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122398/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 12:53 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> I wanted to look into this for longtime, only ended up doing so yesterday when flying home from FOSDEM.
> 
> The idea is simple, we love Quick Open, we get actions on the Quick Open.
> I see it as an approach to what Milian wanted to look into, of having a console to run KDevelop, I think that this with some development could end up quite close. For now, it's already somewhat useful.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/CMakeLists.txt 90e1efd 
>   plugins/quickopen/actionsquickopenprovider.h PRE-CREATION 
>   plugins/quickopen/actionsquickopenprovider.cpp PRE-CREATION 
>   plugins/quickopen/quickopenplugin.h 829e0ab 
>   plugins/quickopen/quickopenplugin.cpp 75ee422 
> 
> Diff: https://git.reviewboard.kde.org/r/122398/diff/
> 
> 
> Testing
> -------
> 
> I played around with it for a while.
> 
> 
> File Attachments
> ----------------
> 
> quickopen-actions.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/b94711e0-837b-42a1-bbee-75b42b797cd9__quickopen-actions.png
> quickopen-actions1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/5665a6bd-7df6-4121-89ab-c12c4a0ebf30__quickopen-actions1.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150203/b594adf3/attachment.html>