Review Request 122398: Actions QuickOpen backend

[Aleix Pol Gonzalez]

> On Feb. 3, 2015, 11:53 a.m., Milian Wolff wrote:
> > plugins/quickopen/quickopenplugin.h, line 130
> > <https://git.reviewboard.kde.org/r/122398/diff/1/?file=346540#file346540line130>
> >
> >     QScopedPointer and remove the explicit delete

I agree, I just don't want to have just this one working differently. I'll do this after the patch is submitted.


> On Feb. 3, 2015, 11:53 a.m., Milian Wolff wrote:
> > plugins/quickopen/quickopenplugin.cpp, line 838
> > <https://git.reviewboard.kde.org/r/122398/diff/1/?file=346541#file346541line838>
> >
> >     we need any scope here, right? sounds odd to have actions of includes, but it's OK if this makes it work.

Yes, I need to see about that. For now, I only copied what I did for the Documentation QuickOpen thingie.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122398/#review75288
-----------------------------------------------------------


On Feb. 3, 2015, 2:26 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122398/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 2:26 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> I wanted to look into this for longtime, only ended up doing so yesterday when flying home from FOSDEM.
> 
> The idea is simple, we love Quick Open, we get actions on the Quick Open.
> I see it as an approach to what Milian wanted to look into, of having a console to run KDevelop, I think that this with some development could end up quite close. For now, it's already somewhat useful.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/CMakeLists.txt 90e1efd 
>   plugins/quickopen/quickopenplugin.h 829e0ab 
>   plugins/quickopen/quickopenplugin.cpp 75ee422 
> 
> Diff: https://git.reviewboard.kde.org/r/122398/diff/
> 
> 
> Testing
> -------
> 
> I played around with it for a while.
> 
> 
> File Attachments
> ----------------
> 
> quickopen-actions.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/b94711e0-837b-42a1-bbee-75b42b797cd9__quickopen-actions.png
> quickopen-actions1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/5665a6bd-7df6-4121-89ab-c12c4a0ebf30__quickopen-actions1.png
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150203/27fad7d6/attachment-0001.html>